[added] onActiveStateChange, onCancelledTransition, onTransitionError Routes props #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just FYI, here is the karma output for the failing specs: |
|
Cool, I'll take a look when I get a spare cycle or two. Thanks for the tests, we need to start taking tests more seriously and I think the harness falls on my shoulders, I'll try to make it friendlier. After the next release we need to beef up our tests too. Does |
|
|
|
I got this passing ... its really strange, I need to spend some time making our test stuff 1000% better. |
|
👎 auth flow example is broken, click on the dashboard before being logged in. |
|
@rpflorence thanks. i'll take a look. |
|
👎 also the transitions example is broken, click on "form" then click on "dashboard" then click "cancel" in the alert. BOOM |
|
@rpflorence did you have any commits to add? or it just passes on your machine? |
|
I amended and force pushed the changes to the branch |
This was referenced Aug 6, 2014
This was referenced Aug 11, 2014
Closed
…outes props Also, removed Routes.handleAsyncError and Routes.handleCancelledTransition
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, removed Routes.handleAsyncError and Routes.handleCancelledTransition.
This PR exposes these handlers as props so they can be overridden by users. The
onTransitionErrorprop is especially useful since it permits users to attach their own error handlers instead of using the default error handler that justthrows (see #151).I've written tests for these new features that all pass when I run them alone. However, when I run
npm testlocally there are 3 failing tests, but I'm not convinced that any of them have to do with my changes. I've digged around quite a bit but can't figure out what's going on in the DOM while the tests are running.@rpflorence Since you're more experienced with karma than I am (and writing DOM tests in general) I thought you might be able to take a look?